Investigate turning off HIP compilation for targets that only depend on hip_runtime
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 296
- Forks
- 66
- Avg merge
- 1h 3m
- Merged PRs (30d)
- 1
Description
@joshessman-llnl - I think the important thing is that anything that depends on `hip` or `hip_runtime` must be linked as hip, so must be passed into `hip_add_executable` or `hip_add_library`.
We could potentially guard this check:
https://github.com/LLNL/blt/blob/995a058193b4ae55daf5d34f0ede1ee1f2d26668/cmake/BLTPrivateMacros.cmake#L568
with `if (${_depends_on_hip})`?
_Originally posted by @davidbeckingsale in https://github.com/LLNL/blt/issues/431#issuecomment-732305116_
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in cmake/BLTPrivateMacros.cmake around line 568 and review the related discussion in issue 431. Determine how targets depending only on hip_runtime are handled versus targets depending on hip, then verify that the intended HIP compilation behavior is preserved for hip-dependent targets while unnecessary compilation is avoided.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cmake
- Domain
- build-system
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100