llnl / llnl/blt

Revamp CUDA support in BLT

Open
#360 4 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

cuda feature
Dominant language
C++
Stars
296
Forks
66
Avg merge
1h 3m
Merged PRs (30d)
1

Description

The CMake code in `SetupCUDA.cmake` seems to be relying on both `find_package(CUDA)`, which was deprecated since CMake 3.10, and the modern first-class CUDA language support in CMake.

Using both is confusing.

This part can be refined and cleaned up quite a bit and we should consider leveraging FindCUDAToolkit(https://cmake.org/cmake/help/latest/module/FindCUDAToolkit.html#) that is available with newer versions of CMake as applicable.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading SetupCUDA.cmake and the CMake documentation for FindCUDAToolkit. Compare the existing find_package(CUDA) usage with the project’s first-class CUDA language support and determine which approach the supported CMake versions allow. Done means the CUDA setup is consistent and no longer confusingly mixes the deprecated and modern mechanisms.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake
Domain
build-system
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.