llnl / llnl/blt

Re-enable blt_combine_static_libraries test on Windows

Open
#182 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
296
Forks
66
Avg merge
1h 3m
Merged PRs (30d)
1

Description

PR #179 disabled the ``SHARED`` variant of the ``blt_combine_static_libraries`` test on Windows due to a linker error.

@white238 noted that there is a known problem with this macro and that he is working on a fix. Once the ``combine_static_libraries`` macro is fixed, we should re-enable this test in our Windows configurations.

Contributor guide

Open the contributing guide

Research direction

Start by reviewing PR #179 and the blt_combine_static_libraries macro, then reproduce the linker error in the Windows configuration. Investigate the known macro problem and re-enable the SHARED variant of the blt_combine_static_libraries test once the Windows configuration passes.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake, cpp
Domain
build-system, testing-qa
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.