gtest undermines pure-c libs use in static builds on windows
Open
Nobody has claimed this yet.
bug
- Dominant language
- C++
- Stars
- 296
- Forks
- 66
- Avg merge
- 1h 3m
- Merged PRs (30d)
- 1
Description
Still narrowing in on the exact issue, but I think this is something we should resolve in BLT's copy of gtest.
Here are more details:
https://github.com/LLNL/conduit/pull/238
And a simpler example I am working on:
https://github.com/cyrush/2017_12_cmake_obj_libs_issue
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the linked Conduit pull request and the simpler CMake object-library example to identify the Windows static-build failure. Then inspect BLT's copy of gtest and reproduce the pure-C library case; done means the example builds and links correctly in the affected configuration.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cmake, cpp
- Domain
- build-system, testing-qa
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100