Add Visual Studio 2012 to our appveyor matrix
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 296
- Forks
- 66
- Avg merge
- 1h 3m
- Merged PRs (30d)
- 1
Description
A user code would like to use BLT for their project, which uses Visual Studio 2012 for their Windows builds.
Our current appveyor setup only tests blt against Visual Studio 2015.
An initial attempt to build blt with VS2012 indicates that there is a problem with gtest and variadic templates. Adding a compiler define to gtest which increases the number of allowed variadic parameters might resolve this problem, e.g. ``_VARIADIC_MAX=10``
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect the current AppVeyor setup that tests BLT with Visual Studio 2015, then compare how gtest is configured for that matrix. Try adding a Visual Studio 2012 build and verify whether the suggested _VARIADIC_MAX=10 define resolves the variadic-template problem; done means the VS2012 job builds and passes in AppVeyor.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cmake, cpp
- Domain
- build-system, ci-cd, testing
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100