llnl / llnl/blt

Proposed enhancement: Use CMakeDependentOption to simplify option logic

Open
#107 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
296
Forks
66
Avg merge
1h 3m
Merged PRs (30d)
1

Description

Is there a reason you're not using the [`CMakeDependentOption`](https://cmake.org/cmake/help/v3.0/module/CMakeDependentOption.html) CMake module for handling option dependencies?

i.e., `ENABLE_GMOCK` depends on `ENABLE_GTEST`, `ENABLE_FRUIT` depends on `ENABLE_FORTRAN` etc.

It would be easy to work up a PR to include this capability. CMake support goes as far back as at least 3.0 if not earlier.

Contributor guide

Open the contributing guide

Research direction

Start by locating the CMake option definitions for ENABLE_GMOCK, ENABLE_GTEST, ENABLE_FRUIT, and ENABLE_FORTRAN. Read CMake's CMakeDependentOption documentation and compare the current dependency behavior. Done means the dependent options are handled consistently without breaking existing configuration behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake
Domain
build-system
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.