llnl / llnl/benchpark

Add conflicts clauses to packages

Open
#879 0 comments 0 reactions 1 assignee View on GitHub

@rfhaque is already working on this.

Since Jul 7, 2025.

bug
Dominant language
Python
Stars
78
Forks
52
Avg merge
4d 19m
Merged PRs (30d)
10

Description

When we have a known issue with specific compilers or library versions, we need to add a conflict to the package to make sure whoever runs into that error again.

One question is whether we should specify the conflict in the benchmark package.py, or at the package.py for the library which throws that error. For now, let's go with the benchmark package.py.

- [ ] Add a conflict to the cuda version in laghos package.py
- [x] Add a conflict to the openapi version in amg2023 package.py
- [x] https://github.com/LLNL/benchpark/pull/878/commits/b3046b045880ed289197c2920c2e63c10f2cf815 solves this via a manual python check in package.py. Notice we cannot use `conflicts`/`depends_on`/`requires` clause since there are multiple compilers defined. `amg` depends on `^intel-oneapi-runtime`, depends on `^gcc-runtime` which needs gcc compiler defined. So conflicting with oneapi causes spack to use the gcc compiler instead, which will happen for any other benchmark which has 1> compiler definitions. Supposedly, concretization checks will be enabled with https://github.com/LLNL/benchpark/pull/849

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.