llnl / llnl/axom

`area(CurvedPolygon)` methods work only with polynomial Bezier curves

Open
#897 0 comments 0 reactions 1 assignee View on GitHub

@jcs15c is already working on this.

Since Aug 11, 2022.

enhancement Primal
Dominant language
C++
Stars
196
Forks
34
Avg merge
4d 1h
Merged PRs (30d)
11

Description

Current methods implemented in compute_moments.hpp work only on nonrational/polynomial Bezier curve objects, in particular area(CurvedPolygon). Methods in evaluate_integral.hpp can be used to compute areas for CurvedPolygon objects when composed of rational Bezier curves (at the cost of an MFEM dependency), so we should consider using these methods in such cases to ensure that area(CurvedPolygon) can be used on the more general case.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.