llnl / llnl/axom

Clean up Umpire allocator logic

Open
#796 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

memory Reviewed TPL usability
Dominant language
C++
Stars
196
Forks
34
Avg merge
4d 1h
Merged PRs (30d)
11

Description

We are mixing how we set/get Umpire allocators (int vs enum). Especially since these two can be implicitly converted to each other. @davidbeckingsale recommends we convert completely to string ("HOST", "DEVICE", etc).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named. Begin by locating Umpire allocator set/get call sites and tracing how allocator values are represented; completion means the allocator handling consistently uses string names such as "HOST" and "DEVICE" without the current int/enum mixing.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
hpc
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.