Remaining Issues with HIP
@bmhan12 is already working on this.
Since Feb 8, 2022.
- Dominant language
- C++
- Stars
- 196
- Forks
- 34
- Avg merge
- 4d 1h
- Merged PRs (30d)
- 11
Description
Tasks from #778 that still remain:
- [x] The shared TPLs are currently located at /usr/WS1/axom/libs/toss_4_x86_64_ib_cray_temp_dir/. The expected build_src.py default, /usr/WS1/axom/libs/toss_4_x86_64_ib_cray/, is a private user-only directory from someone that has left. @white238 is seeing if someone at LC can delete the directory.
- [x] The installed examples (using-with-[cmake/blt/make]) fail and are disabled for hip. These examples are also failing for CUDA and [were already disabled](https://github.com/LLNL/axom/blob/7d595645e7e04e1f88c0f5b5cb265e7328eb0859/scripts/llnl_scripts/llnl_lc_build_tools.py#L444-L450).
- [ ] There is a Fortran executable (quest_inout_interface_F_ex) and unit test (quest_inout_interface_mpi_F_test) that fails to compile with amdclang in a Debug build (File: src/axom/quest/examples/CMakeLists.txt). They are disabled under these conditions.
- [ ] [Suggestion by @kennyweiss convert condition to `Fortran_COMPILER_FAMILY_IS_FOO` type of call](https://github.com/LLNL/axom/pull/778#discussion_r799692199)
- [x] blt is not updated to develop with the hip changes. Still have issue with -lhip_runtime linkage error. [This branch](https://github.com/LLNL/axom/compare/feature/han12%2Fnevada...feature/han12/hipBlt) tracks the current PR and has latest blt with blt::hip.
EDIT:
- [x] Fix spack configs to work with new uberenv/clingo concretizer
EDIT x2:
- [x] mesh_tester executable does not run with hip policy (#856 description for error)
Done in PR #1151
EDIT x3:
- [ ] Investigate axom::Array usage with RAJA::ReduceSum [(PR Comment link)](https://github.com/LLNL/axom/pull/1111#issuecomment-1589659048)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.