llnl / llnl/axom

Investigate performance of different comparators for `StackArray::operator<()`

Open
#761 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Core Performance
Dominant language
C++
Stars
196
Forks
34
Avg merge
4d 1h
Merged PRs (30d)
11

Description

#742 adds a comparison function (operator<()) to axom::StackArray, which implements a lexicographical_compare for a fixed size array.

There were some suggestions for optimizing this function. We should investigate and benchmark a few different approaches and improve the algorithm as appropriate.

See:https://en.cppreference.com/w/cpp/algorithm/lexicographical_compare
But note that the size N is fixed at compile time.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with axom::StackArray::operator<() and review issue #742, then compare its fixed-size lexicographical comparison with the approaches described in cppreference's lexicographical_compare documentation. Benchmark several approaches for compile-time size N and define done as selecting and implementing an evidence-backed improvement.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
performance
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.