MFEMSidreDataCollection should handle Axom configs without HDF5
- Dominant language
- C++
- Stars
- 196
- Forks
- 34
- Avg merge
- 4d 1h
- Merged PRs (30d)
- 11
Description
The `MFEMSidreDataCollection` is hardcoded to use the `sidre_hdf5` protocol by default.
E.g.:
https://github.com/LLNL/axom/blob/833bc1b1d51c633c07b0214f452728f4e2f9b24d/src/axom/sidre/core/MFEMSidreDataCollection.hpp#L454-L458
and
https://github.com/LLNL/axom/blob/833bc1b1d51c633c07b0214f452728f4e2f9b24d/src/axom/sidre/core/MFEMSidreDataCollection.cpp#L938-L944
It should be modified to deal with configurations that do not have hdf5.
E.g. by using `SIDRE_DEFAULT_PROTOCOL` instead:
https://github.com/LLNL/axom/blob/833bc1b1d51c633c07b0214f452728f4e2f9b24d/src/axom/sidre/core/Group.hpp#L42-L47
Contributor guide
Research direction
Start with the cited default-protocol code in src/axom/sidre/core/MFEMSidreDataCollection.hpp and src/axom/sidre/core/MFEMSidreDataCollection.cpp, then compare it with SIDRE_DEFAULT_PROTOCOL in src/axom/sidre/core/Group.hpp. Verify that MFEMSidreDataCollection handles configurations without HDF5 while preserving the existing default behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- hpc
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100