llnl / llnl/axom

Fix fortran openmp linking problem in examples/tests

Open
#581 3 comments 0 reactions 0 assignees View on GitHub
bug Build system design OpenMP Reviewed
Dominant language
C++
Stars
196
Forks
34
Avg merge
4d 1h
Merged PRs (30d)
11

Description

We cannot link directly to `axom` instead of the underlying component (`slic` for example) in examples or tests due to the wrong openmp link flag showing up. This affects users as well.

I swapped over as many internal executables in this PR but fortran ones specifically could not be moved over: #580

Contributor guide

Open the contributing guide

Research direction

Start by comparing the Fortran executables in the examples and tests with the internal executable changes described in pull request #580. Trace how the OpenMP link flag is selected when linking directly to axom versus the underlying component such as slic. Done means the Fortran examples and tests link through axom correctly without exposing the wrong OpenMP flag.

Written by the indexing model from the issue text.

Assessment

Tech stack
fortran
Domain
build-system
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.