llnl / llnl/axom

Move assignment operators in inlet

Open
#464 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug Inlet
Dominant language
C++
Stars
196
Forks
34
Avg merge
4d 1h
Merged PRs (30d)
11

Description

There are a few classes in inlet that have move constructors but not move assignment operators. This makes it impossible to assign fields of this type in an object if they cannot be assigned in a constructor. I found this to be the case for the objects below, though there may be more.

- `Inlet`
- `Table`
- `Verifiable` (no move constructor or move assignment operator, but regular assignment operator is deleted, while copy constructor is not)

I was going to just submit a PR for `Inlet`, but when I found the others, I thought I'd create the issue instead in case this implies further changes are needed as well.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the Inlet, Table, and Verifiable class definitions and inspect their move constructors and copy or assignment operators. Check whether other inlet classes have the same gap; done means the affected types support the intended assignment behavior consistently, with any relevant assignment cases verified.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.