llnl / llnl/axom

following #350, audit tests that relied on SLIC rewire of errors to pass

Open
#353 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Reviewed
Dominant language
C++
Stars
196
Forks
34
Avg merge
4d 1h
Merged PRs (30d)
11

Description

In these cases, there may be patterns that lead to error conditions that are simply ignored in the test - but could lead to a crash with similar use in a sim code. We should understand.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or specific tests are named. Start by locating tests that rely on SLIC to rewire errors, then inspect whether error conditions are ignored; done means the affected cases are understood and tests no longer hide conditions that could cause crashes in similar simulation code.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
hpc, testing-qa
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.