Enable InOutOctree to run with 64 bit indexes
Open
@kennyweiss is already working on this.
Since Jul 10, 2020.
enhancement
Quest
Reviewed
Spin
- Dominant language
- C++
- Stars
- 196
- Forks
- 34
- Avg merge
- 4d 1h
- Merged PRs (30d)
- 11
Description
The InOutOctree has a max depth of 32 levels due to its dependence on axom::IndexType for the (integer) coordinates of each octree block.
@agcapps reported a problem that a user encountered in the quest in/out query where 32 levels was insufficient to separate the mesh's inside from its outside.
To resolve this, axom's octree class should either:
- Support 64-bit indexes when
axom::IndexType == int64 - Add an extra configuration option to allow 64-bit indexes, regardless of the value of
axom::IndexType
(or more likely, it should support both of these cases, with a default CoordType of axom::IndexType)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.