llnl / llnl/axom

Follow-up tasks for TPL CI improvements

Open
#162 1 comment 0 reactions 1 assignee View on GitHub

@kennyweiss is already working on this.

Since Dec 13, 2021.

CI maintenance Reviewed Testing TPL
Dominant language
C++
Stars
196
Forks
34
Avg merge
4d 1h
Merged PRs (30d)
11

Description

@keithhealy has significantly improved our CI testing by adding docker images with pre-built TPLs (#155 )

This issue tracks some unresolved tasks:
- [x] Build ``RAJA`` directly using our uberenv. @keithhealy ran into trouble building ``RAJA`` through docker and our current dockerfile's are building ``RAJA`` separately.
- [ ] Generate TPLs for our ``Windows`` config on azure (@agcapps is working on this) and re-enable ``sidre`` for this config
- [ ] Add unit test to ``Windows`` config on azure
- [ ] Generate TPL's for our ``OS X`` builds, and re-enable ``sidre`` for this config.
- [x] Ensure that azure marks a build as failing if it fails unit tests. In the current iteration, this does not appear to be the case (see: https://dev.azure.com/axom/axom/_build/results?buildId=877&view=ms.vss-test-web.build-test-results-tab , where the ``sidre_lulesh`` tests are failing on the gcc configurations, but azure/github says that all checks are passing)
- [x] Fix ``sidre_lulesh`` test on gcc configurations. Perhaps reducing the number of threads on the ctest invocation would help? E.g. change ``j10`` to ``j8`` (or lower)
- [x] Update clang configurations to clang 8 and clang 9, instead of clang 4, 5 and 6 (per @rhornung67's request)
- [x] Update clang compiler images to include a working gfortran (@davidbeckingsale ?)
- [ ] Consider removing ``docker_`` prefix from docker host-configs, since they are already located in the ``docker/`` directory (per @gzagaris's request)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.