Making timeout units consistent
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 122
- Forks
- 34
- PR merge metrics
- No merged PRs in 30d
Description
Current configuration allows setting three timeouts, but they don't use the same unit.
margo section:
- client_timeout: timeout in milliseconds for rpcs between client and server (default: 5000)
- server_timeout: timeout in milliseconds for rpcs between servers (default: 15000)
server section:
- init_timeout: timeout in seconds to wait for servers to be ready for clients (default: 120)
Maybe better to make the three timeout units the same? Probably all use seconds.
Otherwise, It can be confusing when checking a job script with all three environment variables:
```bash
export UNIFYFS_SERVER_INIT_TIMEOUT=600
export UNIFYFS_MARGO_CLIENT_TIMEOUT=60000
export UNIFYFS_MARGO_SERVER_TIMEOUT=60000
```
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the margo client_timeout and server_timeout settings alongside server init_timeout and their environment variables: UNIFYFS_MARGO_CLIENT_TIMEOUT, UNIFYFS_MARGO_SERVER_TIMEOUT, and UNIFYFS_SERVER_INIT_TIMEOUT. Confirm the intended common unit and update the configuration behavior and documentation so all three settings use it consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- operating-systems
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100