range_server_bget_op() inconsistent logic for op == MDHIM_GET_NEXT
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 122
- Forks
- 34
- PR merge metrics
- No merged PRs in 30d
Description
On this line we have if (op != MDHIM_GET_NEXT) {
Yet inside the if body there is code to handle op == MDHIM_GET_NEXT:
https://github.com/LLNL/UnifyCR/blob/2cc38254e3bf25a07c2619bf5fdc577725568869/meta/src/range_server.c#L1042
and
https://github.com/LLNL/UnifyCR/blob/2cc38254e3bf25a07c2619bf5fdc577725568869/meta/src/range_server.c#L1055
I'd like to restructure this function to reduce the nesting level and improve readability. Resolving the above inconsistency will help guide the restructuring. Should the handlers for MDHIM_GET_NEXT within the if body be removed, or is the if conditional statement just wrong? Is there a way to test whether this operation is being handled correctly?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in meta/src/range_server.c at range_server_bget_op(), especially the condition near lines 1029, 1042, and 1055. Trace the MDHIM_GET_NEXT path and determine whether the condition or its handlers match the intended behavior; done means the control flow is consistent, nesting is clearer, and the operation has regression coverage.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- operating-systems
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100