llnl / llnl/UnifyFS

laminate on transfer

Open
#407 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
122
Forks
34
PR merge metrics
No merged PRs in 30d

Description

Using the unifyfs_transfer call to transfer a file in from the real file system to unify, @craigsteffen found that the file was not being laminated. We likely will optionally want this to laminate files in unify after transferring a file in. Perhaps that could be added as an option to the unifyfs_transfer API?

For laminating a file after a transfer, I think we’d want to make a call to chmod() after calling the unifyfs_transfer_* functions here:
https://github.com/LLNL/UnifyFS/blob/a58c74c0e54911db4063e464526a8ddb7eb9ca8d/examples/src/transfer.c#L153

Or we could add an optional call to chmod() within the implementation of the unifyfs_transfer function itself:
https://github.com/LLNL/UnifyFS/blob/a58c74c0e54911db4063e464526a8ddb7eb9ca8d/client/src/unifyfs.c#L2808

And then once we get a unifyfs_laminate() call, the chmod() added here should be replaced.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with examples/src/transfer.c near line 153 and client/src/unifyfs.c near line 2808, tracing the unifyfs_transfer_* calls and current chmod behavior. Clarify whether the option belongs in the transfer API or example, and account for the future unifyfs_laminate() call; done should make the intended optional post-transfer lamination behavior explicit and tested.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
operating-systems
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
32/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.