llnl / llnl/Spindle

CI should not run on draft PRs, closing pull request should cancel outstanding CI run

Open
#112 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
110
Forks
35
Avg merge
1d 16h
Merged PRs (30d)
2

Description

  1. Currently, the CI workflow tries to run (and requests review) in all PRs, including draft PRs. Instead, don't run CI until marked ready for review. Relevant discussion here: https://github.com/orgs/community/discussions/120231
  2. Currently, closing a PR with waiting, unreviewed CI workflows leaves the request for review open. Instead, cancel waiting workflows when the associated PR is closed. Relevant discussion here: https://github.com/orgs/community/discussions/62390

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Inspect the repository's GitHub Actions workflow configuration and compare its behavior for draft, ready-for-review, and closed pull requests. Use the linked discussions as context, then verify that draft PRs do not start CI or request review and that waiting workflows are canceled when a PR closes.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions
Domain
ci-cd
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.