llnl / llnl/Silo

testsilock and maybe other sh testing code not posix compliant

Open
#92 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
45
Forks
27
Avg merge
12h 34m
Merged PRs (30d)
4

Description

Ubuntu uses /bin/dash in place of /bin/sh. But, most /bin/sh are really /bin/bash. Most of silo's tests that use scripts work fine on /bin/bash but may contain bashisms and other nonposix-compliant shell code that will fail on ubunto. Test everything with dash.

-----------------------REDMINE MIGRATION-----------------------
This ticket was migrated from Redmine. As such, not all
information was able to be captured in the transition. Below is
a complete record of the original redmine ticket.

Ticket number: 650
Status: New
Project: VisIt
Tracker: Bug
Priority: Normal
Subject: testsilock and maybe other sh testing code not posix compliant
Assigned to: -
Category: -
Target version: -
Author: Mark Miller
Start: 03/14/2011
Due date:
% Done: 0%
Estimated time:
Created: 03/14/2011 10:59 pm
Updated:
Likelihood: 3 - Occasional
Severity: 2 - Minor Irritation
Found in version: 4.8
Impact:
Expected Use:
OS: All
Support Group: Any
Description:
Ubuntu uses /bin/dash in place of /bin/sh. But, most /bin/sh are really /bin/bash. Most of silo's tests that use scripts work fine on /bin/bash but may contain bashisms and other nonposix-compliant shell code that will fail on ubunto. Test everything with dash.

Comments:

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the testsilock script and identify the other shell-based test scripts referenced by the issue. Run the test suite using dash as /bin/sh, then inspect any failures for non-POSIX shell usage. Done means the relevant tests pass under dash as well as bash.

Written by the indexing model from the issue text.

Assessment

Tech stack
bash, shell
Domain
testing-qa
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.