llnl / llnl/Silo

remove silo config-isms from lite_score.h

Open
#48 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
45
Forks
27
Avg merge
12h 34m
Merged PRs (30d)
4

Description

A Division folks ran into a problem using PDB Lite because lite_score.h includes refs like. . . #if HAVE_STDLIB_H # include <stdlib.h> #endif #if HAVE_STRING_H # include <string.h> #endif #if HAVE_SYS_TYPES_H # include <sys/types.h> #endif #ifndef HAVE_MEMMOVE LITE_API extern void ** memmove (void**,const void*,size_t) ; #endif the definitions of the HAVE_XXX symbols from from Silo's configure, config.h which is not an installed file.

-----------------------REDMINE MIGRATION-----------------------
This ticket was migrated from Redmine. As such, not all
information was able to be captured in the transition. Below is
a complete record of the original redmine ticket.

Ticket number: 2236
Status: New
Project: VisIt
Tracker: Bug
Priority: Normal
Subject: remove silo config-isms from lite_score.h
Assigned to: -
Category: -
Target version: -
Author: Mark Miller
Start: 04/20/2015
Due date:
% Done: 0%
Estimated time:
Created: 04/20/2015 06:54 pm
Updated:
Likelihood: 3 - Occasional
Severity: 2 - Minor Irritation
Found in version: 4.8
Impact:
Expected Use:
OS: All
Support Group: Any
Description:
A Division folks ran into a problem using PDB Lite because lite_score.h includes refs like. . . #if HAVE_STDLIB_H # include <stdlib.h> #endif #if HAVE_STRING_H # include <string.h> #endif #if HAVE_SYS_TYPES_H # include <sys/types.h> #endif #ifndef HAVE_MEMMOVE LITE_API extern void ** memmove (void**,const void*,size_t) ; #endif the definitions of the HAVE_XXX symbols from from Silo's configure, config.h which is not an installed file.

Comments:

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading lite_score.h and checking how its HAVE_* references depend on Silo's configure-generated config.h. Confirm the public PDB Lite header no longer requires that uninstalled file, then verify that the header remains usable by its consumers.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
build-system
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.