llnl / llnl/Silo

fix can_apply method for hzip filter

Open
#148 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
45
Forks
27
Avg merge
12h 34m
Merged PRs (30d)
4

Description

Presently, the can_apply method for the hzip filter is always saying 'yes' and the real logic to determine if there is a problem is handled either in the actual filter op or in the various DBPrepare... methods that decide whether to have the filter turned on or not.

-----------------------REDMINE MIGRATION-----------------------
This ticket was migrated from Redmine. As such, not all
information was able to be captured in the transition. Below is
a complete record of the original redmine ticket.

Ticket number: 1187
Status: New
Project: VisIt
Tracker: Bug
Priority: Normal
Subject: fix can_apply method for hzip filter
Assigned to: -
Category: -
Target version: -
Author: Mark Miller
Start: 08/30/2012
Due date:
% Done: 0%
Estimated time:
Created: 08/30/2012 08:48 pm
Updated:
Likelihood: 3 - Occasional
Severity: 2 - Minor Irritation
Found in version: 4.8
Impact:
Expected Use:
OS: All
Support Group: Any
Description:
Presently, the can_apply method for the hzip filter is always saying 'yes' and the real logic to determine if there is a problem is handled either in the actual filter op or in the various DBPrepare... methods that decide whether to have the filter turned on or not.

Comments:

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the hzip filter's can_apply method, then compare it with the filter operation and the DBPrepare... methods mentioned in the issue. Determine the conditions that indicate the filter cannot be applied; the work is done when can_apply reports those conditions consistently instead of always returning yes.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
databases
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.