llnl / llnl/Silo

Support units specified in defined variables from Silo

Open
#112 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
45
Forks
27
Avg merge
12h 34m
Merged PRs (30d)
4

Description

I am not sure we support units for expressions in VisIt. However, Silo's DBPutDefvars call allows callers to define units for the expressions. A user has requested these be visible in VisIt just as units on ordinary variables are. This may or may not be a lot of work. We don't support units through expressions right now. We probably ought to. But, all that is needed to satisfy this is to ensure that whatever units the Silo file said should be associated with the RESULT of an expression should just be bound to them. So, it doesn't really require that expressions support units, just bind any units specified by the database upon completing the expression.

-----------------------REDMINE MIGRATION-----------------------
This ticket was migrated from Redmine. As such, not all
information was able to be captured in the transition. Below is
a complete record of the original redmine ticket.

Ticket number: 176
Status: Pending
Project: VisIt
Tracker: Feature
Priority: Normal
Subject: Support units specified in defined variables from Silo
Assigned to: -
Category: -
Target version: -
Author: Mark Miller
Start: 06/24/2010
Due date:
% Done: 0%
Estimated time: 8.00 hours
Created: 06/24/2010 04:59 pm
Updated: 07/06/2010 08:57 pm
Likelihood:
Severity:
Found in version: 2.12.3
Impact: 2 - Low
Expected Use: 3 - Occasional
OS: All
Support Group: Any
Description:
I am not sure we support units for expressions in VisIt. However, Silo's DBPutDefvars call allows callers to define units for the expressions. A user has requested these be visible in VisIt just as units on ordinary variables are. This may or may not be a lot of work. We don't support units through expressions right now. We probably ought to. But, all that is needed to satisfy this is to ensure that whatever units the Silo file said should be associated with the RESULT of an expression should just be bound to them. So, it doesn't really require that expressions support units, just bind any units specified by the database upon completing the expression.

Comments:

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with Silo's DBPutDefvars metadata and the VisIt path that imports defined variables and completes expression results. Trace how units on ordinary variables are attached, then verify that units supplied for the expression result are preserved and visible in VisIt; no test or file is named in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
databases
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.