Change HIP makefiles to not use ${HIP_PATH}
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 4
- Forks
- 3
- PR merge metrics
- No merged PRs in 30d
Description
AMD has begun the process of moving header files from /opt/rocm/${ROCM_PACKAGE}/include to /opt/rocm/include with rocm/5.4.0. Using the older include locations will emit an error starting with rocm/6.0.0.
Currently the rocm/5.5.0 modules on tioga on not setting ${HIP_PATH}, which causes build errors when running
cd SW4CK/src
module load rocm/5.5.0
make -f Makefile.hip
in the form
ld.lld: error: /lib/libm.so is incompatible with elf64-x86-64
ld.lld: error: /lib/libdl.so is incompatible with elf64-x86-64
ld.lld: error: /lib/libm.so is incompatible with elf64-x86-64
...
due to a damaged -L path in this file. A temporary workaround is just to add export HIP_PATH=${ROCM_PATH} by the compilation.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with src/configs/make.hip at the referenced line and reproduce the failure using the SW4CK/src command sequence with module rocm/5.5.0. Inspect how the damaged -L path is formed and compare it with the documented ROCm include locations. Done means the HIP makefile no longer depends on HIP_PATH and the stated build completes without the linker errors.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100