Bug in BaseGridGeometry::readBlockDataFromInput

the BoxId of sing_box is not set before it is pushed to BaseGridGeometry::d_singularity (hier/BaseGridGeometry.C:2152 and 2223). It will not have negative effect until you want to restart. Box of of d_singularity[blockid] has incorrect BoxId and it is dumped to Restart file. When you are going to read the restart file, an assert failed.

We can observe the bug in an configuration with singularity, e.g., test/MblkLinAdv. Try to run it with restart and the bug occur.

Start in hier/BaseGridGeometry.C at lines 2152 and 2223, then reproduce the problem with the test/MblkLinAdv configuration using restart. Trace how sing_box is added to BaseGridGeometry::d_singularity and how its BoxId is written and read in the restart file. Done means the restart run no longer hits the assertion and the singularity boxes retain the correct BoxId.

Written by the indexing model from the issue text.