hier::Patch should return shared_ptr by const reference
Open
@nselliott is already working on this.
Since Oct 18, 2018.
- Dominant language
- C++
- Stars
- 250
- Forks
- 89
- Avg merge
- 34m
- Merged PRs (30d)
- 1
Description
Is there any reason why hier::Patch does return its class member of type std::shared_ptr's by value instead of by reference to const std::shared_ptr? Each time I want to access the hier::PatchGeometry or hier::PatchData members I have to take a lock to increase the reference count of std::shared_ptr. Returning references instead would allow having the freedom to decide for myself if I want to do this.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.