llnl / llnl/SAMRAI

Makefile Include Directory

Open
#4 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
250
Forks
89
Avg merge
34m
Merged PRs (30d)
1

Description

In the file `config/Makefile.config.in`, I believe the line:

```
INCLUDE_SAM = $(SAMRAI)/source
```

Should be:
```
INCLUDE_SAM = $(SAMRAI)/include
```

Otherwise after `make install`, the `SAMRAI-v3.11.2/install/config/Makefile.config` file doesn't give the user application the correct includes directory, which should be something like `SAMRAI-v3.11.2/install/include`, for example.

Contributor guide

Open the contributing guide

Research direction

Start with config/Makefile.config.in and inspect how the INCLUDE_SAM value is used during make install. Confirm that the generated install/config/Makefile.config points applications to the installed include directory rather than source, then verify the installed configuration reflects the intended path.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
build-system
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.