llnl / llnl/SAMRAI

Direct Accessing d_boxes in PatchLevel

Open
#28 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
250
Forks
89
Avg merge
34m
Merged PRs (30d)
1

Description

PatchLevel.C: Line 452 and 618: d_boxes are directly accessed, it can be uninitialized when accessing, e.x. if you are from a restart, ranges of boxes in d_boxes are read boxes are not initialized.
Use PatchLevel::getBoxes() instead.

Contributor guide

Open the contributing guide

Research direction

Open PatchLevel.C and inspect the direct d_boxes accesses at lines 452 and 618, then read PatchLevel::getBoxes() to understand the intended access path. Check the restart scenario described in the issue and confirm both accesses use getBoxes() so uninitialized box ranges are not read.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
hpc
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.