Multiblock in restart
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 250
- Forks
- 89
- Avg merge
- 34m
- Merged PRs (30d)
- 1
Description
If it is not a restart case, TimeRefinementIntegrator::initializeHierarchy will call PatchHierarchy::makeCoarsestLevel and then call adjustMultiblockPatchLevelBoundaries at the coarsest level, and Patch will have correct PatchGeometry in all following simulations. In restart case, adjustMultiblockPatchLevelBoundaries is never called during initialization. Patch will have incorrect PatchGeometry in multiblock case (all face, edge, node boundaries will be regarded as physical boundaries), unless I called adjustMultiblockPatchLevelBoundaries in my own code from coarsest level to finest level.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at TimeRefinementIntegrator::initializeHierarchy and trace the restart initialization path, comparing it with the non-restart path that calls PatchHierarchy::makeCoarsestLevel and adjustMultiblockPatchLevelBoundaries. Done means restarted multiblock simulations initialize PatchGeometry correctly for face, edge, and node boundaries without requiring application code to make the calls.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- hpc
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100