llnl / llnl/SAMRAI

PersistentOverlapConnectors::findConnector is resorting to a global search to find overlaps

Open
#215 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
250
Forks
89
Avg merge
34m
Merged PRs (30d)
1

Description

I regularly see this message as the last of my logs before simulations appear to be crashed or stalled :

```
samrai/source/SAMRAI/hier/PersistentOverlapConnectors.cpp line :473 message: PersistentOverlapConnectors::findConnector is resorting
to a global search to find overlaps between 0x4f6a600 and 0x4f6a600.

This relies on unscalable data or triggers unscalable operations.
Number of implicit global searches: 850

```

I only have this message for simulations running with the TileClustering, never with BergerRigoutsos.

any hint regarding what may be the source of this?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at samrai/source/SAMRAI/hier/PersistentOverlapConnectors.cpp around line 473 and trace why findConnector falls back to a global search. Compare the behavior for TileClustering and BergerRigoutsos, using the reported log and implicit global-search count as evidence. Done means identifying the source of the repeated fallback and documenting or addressing the unscalable operation.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
hpc, performance
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.