llnl / llnl/SAMRAI

Question: is it possible that the box generator generates a patch which does not touch physical boundaries but has ghost cells out of physical boundaries?

Open
#192 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
250
Forks
89
Avg merge
34m
Merged PRs (30d)
1

Description

My application needs special treatment when ghost cells out of the physical boundary are used in calculating the fluxes, and for this reason I need to know whether a patch has ghost cells out of the boundary or not.

I use PatchGeometry::getCodimensionBoundaries(int) to determine if a patch touches the physical boundary and in which direction. However, would it be possible that a patch does not actually touch the physical boundary but has ghost cells out of physical boundary?

For example, the index range of the domain is [0, N], and the patch has index range [1, N-1], but a PatchData has ghost width 2.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by examining PatchGeometry::getCodimensionBoundaries(int), the box generator, and the relationship between the domain index range, patch index range, and PatchData ghost width. Determine whether a patch such as [1, N-1] with ghost width 2 can have ghost cells outside the physical boundary, then document the answer and the appropriate boundary check for users.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
hpc
Issue type
Documentation
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.