bugs in algs::MethodOfLinesIntegrator
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 250
- Forks
- 89
- Avg merge
- 34m
- Merged PRs (30d)
- 1
Description
Hello, in algs/MethodOfLineIntegrator.C:Line252, the ghost cells at the level ln are filled by the patch data in the coarser level ln-1, but the patch date at that coarser level has already been updated to the next stages.
that's to say, you are trying to fill the ghost cell with data that has a different time stamp.
Also, the data should be coarsen from the finest level to the coarsest level, that's to say, Line 276 should be called from ln = nlevel-1 to 1. However, it is called from 1 to nlevel-1.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading algs/MethodOfLineIntegrator.C around lines 252 and 276, tracing which level and stage supply ghost-cell data. Verify that ghost fills use matching time stamps and that the level-processing order runs from nlevel-1 down to 1; done means both reported ordering and time-stage issues are addressed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- hpc
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100