llnl / llnl/SAMRAI

small bugs in test case MblkLinAdv

Open
#1 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
250
Forks
89
Avg merge
34m
Merged PRs (30d)
1

Description

small bugs in test case MblkLinAdv.
1. MblkLinAdv.C Line 571 & 572. It should be d_center[1] and d_center[2]
2. Test input octant_3blk.3d.input. The Multiblock GridGeometry is not correctly mapped to the physical xyz coordinates in MblkGeometry.C. i.e., the neighbourhood relation in octant_3blk.3d.input is not the same as the physical neighbourhood relation when it is constructed by MblkGeometry.C. It could be fixed by exchanging Block 1 and Block 2 in octant_3blk.3d.input.

Contributor guide

Open the contributing guide

Research direction

Start with MblkLinAdv.C lines 571-572 and the octant_3blk.3d.input test input, then inspect MblkGeometry.C to compare block mappings with physical xyz neighborhoods. Done means correcting the two d_center references and making the input's neighborhood relation match the physical relation constructed by MblkGeometry.C.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
hpc, testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.