llnl / llnl/RAJAPerf

Calls to Kokkos::min and Kokkos:max are incorrect if ENABLE_KOKKOS=On

Open
#323 10 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Jupyter Notebook
Stars
135
Forks
55
Avg merge
4d 16h
Merged PRs (30d)
5

Description

I've been trying to build RAJAPerf with the cmake option `ENABLE_KOKKOS=On` but it fails with two error messages,
```
"/home/dog/kokkos/testing/RAJAPerf/src/basic-kokkos/REDUCE3_INT-Kokkos.cpp", line 58: error: namespace "Kokkos" has no member "min"
m_vmin = Kokkos::min(m_vmin, static_cast(min_value));
^

"/home/dog/kokkos/testing/RAJAPerf/src/basic-kokkos/REDUCE3_INT-Kokkos.cpp", line 59: error: namespace "Kokkos" has no member "max"
m_vmax = Kokkos::max(m_vmax, static_cast(max_value));
^
```

Steps to reproduce:
```
$ module load cmake
$ module load nvhpc/23.1
$ git clone --recursive https://github.com/LLNL/RAJAPerf.git
$ cd RAJAPerf
$ mkdir build; cd build
$ cmake -DENABLE_KOKKOS=On ..
$ make -j
```

It appears to be a simple case issue. The correct call should be to `Kokkos::Min` and `Kokkos:Max`, respectively.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with src/basic-kokkos/REDUCE3_INT-Kokkos.cpp at the calls reported on lines 58-59. Configure with -DENABLE_KOKKOS=On and run make -j to reproduce the compiler errors; done means the Kokkos-enabled build completes without these errors.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake, cpp
Domain
backend
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.