llnl / llnl/Quicksilver

Functions declarations have HOST_DEVICE_CUDA but definitions

Open
#33 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
47
Forks
37
PR merge metrics
No merged PRs in 30d

Description

In MC_Particle.hh:
Function declaration of Move_Particle uses HOST_DEVICE_CUDA:
```
HOST_DEVICE_CUDA
void Move_Particle(const DirectionCosine & direction_cosine, const double distance);
```
but function definition does not:
`inline void MC_Particle::Move_Particle( const DirectionCosine &my_direction_cosine, …`

In file ParticleVault.hh:
`putParticle` is declared as HOST_DEVICE_CUDA, but the function definition does not use HOST_DEVICE_CUDA.
`invalidateParticle` is declared as HOST_DEVICE_CUDA, but the function definition does not use HOST_DEVICE_CUDA.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in MC_Particle.hh and ParticleVault.hh, locating the declarations and definitions of Move_Particle, putParticle, and invalidateParticle. Compare the HOST_DEVICE_CUDA annotations across each pair; done means all three definitions match their declarations and the affected CUDA build or checks pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
hpc
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.