llnl / llnl/LaunchMON

known issues with flux

Open
#63 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
13
Forks
10
PR merge metrics
No merged PRs in 30d

Description

from #51
Known issues to resolve:

test.attach_4_shutdownbe doesn't completely work. We use tools/flux/flux-helper.sh (bash script) to bulk launch the tool daemons and we need to kill this process sufficiently good enough (a.k.a. kill support) so that flux exec used in the script gets killed as well. rm_flux.conf is configured to send two consecutive SIGINTs to this process but bash wouldn't be killed. Here, the way the signal is sent which is essentially equivalent to kill -INT but this isn't good enough. If this were kill -INT -PID (note minus PID), I think this would kill both flux-helper.sh and flux exec processes sufficiently. But this can have other side effects since this will send SIGINT to the group that share the terminal. So I decide to revisit this later as part of hardening. The way we do bulk launch with Flux may change as well. Please see https://github.com/flux-framework/flux-core/issues/3110#issuecomment-668893081.

No attempt was made to add support launch mode including porting test codes.

Had mild levels of testing to make sure this doesn't break other resource managers like SLURM. But we need whole lot more. (Really need CI).

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with test.attach_4_shutdownbe, tools/flux/flux-helper.sh, and rm_flux.conf to understand the shutdown behavior and signal handling. Review the linked Flux issue and existing resource-manager tests, including the limited SLURM coverage. Done means the Flux shutdown case and launch-mode support are addressed without breaking other resource managers, with broader testing or CI coverage.

Written by the indexing model from the issue text.

Assessment

Tech stack
bash, cpp
Domain
hpc, testing-qa
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.