llnl / llnl/LaunchMON

bashisms in configure

Open
#59 0 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
13
Forks
10
PR merge metrics
No merged PRs in 30d

Description

when using SHELL=/bin/dash and CONFIG_SHELL=/bin/dash I get this but the configure continue and I have build failure later

checking for MUNGE... yes                                                                                                                                                                                                                   
./configure: 6276: test: x-lmunge : unexpected operator                                                                                                                                                                                     
checking for munge.h... yes                                                                                           
checking for munge_encode in -lmunge... yes                                                                           
./configure: 6350: test: xtrue: unexpected operator                                                                                                                                                                                         
./configure: 6358: test: x: unexpected operator        
./configure: 6362: test: x: unexpected operator     
./configure: 6392: test: x: unexpected operator  
./configure: 6399: test: x: unexpected operator                                                                                                                                                                                             
./configure: 6406: test: x: unexpected operator                      

the following lines in the configure fail

if test "x$MUNGE_LIBS" == "x"; then
if test "x$WANT_MUNGE" == "xtrue"; then
if test "x$WANT_KEYFILE" == "xtrue"; then
if test "x$WANT_NOSEC" == "xtrue"; then
if test "x$MUNGE" == "xtrue"; then
if test "x$ENABLE_NULL_ENCRYPTION" == "xtrue"; then

replacing == with = in https://github.com/LLNL/LaunchMON/blob/master/config/x_ac_handshake.m4 should work

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Inspect config/x_ac_handshake.m4 and the listed configure checks, then reproduce the issue with SHELL=/bin/dash and CONFIG_SHELL=/bin/dash. Confirm that the generated configure script no longer reports unexpected-operator errors and that the MUNGE-related configuration completes successfully.

Written by the indexing model from the issue text.

Assessment

Tech stack
shell
Domain
build-system
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.