Possible typo in Fanfiction data processing
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 50
- Forks
- 8
- PR merge metrics
- No merged PRs in 30d
Description
Hi @rrivera1849 , thanks a lot for making the code as well as model public. I had a question about the Fanfiction dataset.
In https://github.com/LLNL/LUAR/blob/main/scripts/preprocess_pan_into_paragraphs.py#L53, should `seen_data[author].add(data.iloc[idx].pair[1])` actually be `seen_data[author].add(data.iloc[idx].pair[0])`?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read scripts/preprocess_pan_into_paragraphs.py at line 53 and inspect how the dataset's pair values are used around that statement. Confirm which pair element should be recorded for each author, then verify the preprocessing result with the corrected choice.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data-engineering, machine-learning
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100