Equation for Rayleigh number in LH2Simulate.m
Nobody has claimed this yet.
- Dominant language
- MATLAB
- Stars
- 13
- Forks
- 8
- PR merge metrics
- No merged PRs in 30d
Description
Dear researchers, thank you very much for publishing the simulation code!
I have a question conserning the formula for the Rayleigh number in LH2Simulate.m file (for example, in line 409):
Maybe I have missunderstood something, but could it be possible that in this equation the kinematic viscosity should be squared? I found the following equation for the Rayleigh number:
Please correct me if I am wrong.
Thank you very much in advance!
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in LH2Simulate.m around line 409 and compare the implemented Rayleigh-number formula with the referenced equation and surrounding variable definitions. Review the existing comment discussion before deciding whether the expression is incorrect; done means the formula is confirmed or corrected and the result is documented or validated in the simulation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- matlab
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100