llnl / llnl/LEAP

Compilation with cpu_CMakeLists.txt fails

Open
#188 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Cuda
Stars
249
Forks
37
PR merge metrics
No merged PRs in 30d

Description

Hi,
there seems to be some missing #ifdef __USE_CPU in filtered_backprojection.cpp. The project does not build from master because several GPU specific functions aren't available.

[build] /home/andrew/workspace/LEAP/src/filtered_backprojection.cpp: In member function ‘bool filteredBackprojection::filterProjections(float*, float*, parameters*, bool)’:
[build] /home/andrew/workspace/LEAP/src/filtered_backprojection.cpp:282:37: error: ‘zeroPadForOffsetScan_GPU’ was not declared in this scope; did you mean ‘zeroPadForOffsetScan’?
[build] 282 | g = zeroPadForOffsetScan_GPU(g, params, g_out);
[build] | ^~~~~~~~~~~~~~~~~~~~~~~~
[build] | zeroPadForOffsetScan
[build] /home/andrew/workspace/LEAP/src/filtered_backprojection.cpp: In member function ‘bool filteredBackprojection::execute(float*, float*, parameters*, bool, bool, bool)’:
[build] /home/andrew/workspace/LEAP/src/filtered_backprojection.cpp:459:41: error: ‘zeroPadForOffsetScan_GPU’ was not declared in this scope; did you mean ‘zeroPadForOffsetScan’?
[build] 459 | g_pad = zeroPadForOffsetScan_GPU(g, params);
[build] | ^~~~~~~~~~~~~~~~~~~~~~~~
[build] | zeroPadForOffsetScan
[build] /home/andrew/workspace/LEAP/src/filtered_backprojection.cpp:505:33: error: ‘cudaFree’ was not declared in this scope
[build] 505 | cudaFree(g_pad);

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with src/filtered_backprojection.cpp and the CPU configuration in cpu_CMakeLists.txt. Reproduce the CPU-only build and inspect the reported calls to GPU functions and cudaFree. Done means the project compiles successfully with the CPU CMake configuration without GPU-only symbols.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake, cpp
Domain
build-system
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.