llnl / llnl/LEAP

Regarding the ColVectors Direction Issue in Modular Reconstruction

Open
#175 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Cuda
Stars
249
Forks
37
PR merge metrics
No merged PRs in 30d

Description

Hi Kyle,

Image

I have encountered an issue with the direction definition when using the modularbeam reconstruction you provided. In the LEAP.pdf file you provided, I understand that the direction of ColVector is consistent with the i direction (indicated by the bold arrow). However, in the d04_madulalbeam.py sample you provided, the direction of ColVector is opposite to the i direction. Please tell me what the correct direction should look like?

thank you!

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare the ColVector convention described in LEAP.pdf with the direction used by the d04_madulalbeam.py sample, using the attached image as context. First inspect both references and trace how the direction is defined in the modularbeam reconstruction. Done means resolving the discrepancy and documenting the correct convention.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
computer-vision
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.