llnl / llnl/INGRID

Grid validity check

Open
#9 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
11
Forks
9
PR merge metrics
No merged PRs in 30d

Description

Hello, I want to help add a feature to automatically check the grid validity at the end and graphically flag any cells with problems. The shapely library makes it easy to check that cells are not twisted (polygon.is_valid) and that they touch but don't overlap their neighbors (polygon1.touches(polygon2)). I've added the is_valid check, but the overlap check is more subtle because the poloidal indices jump at target plates and X-points. Since I am not very familiar with the codebase yet, is there a simple way, compatible across the different topologies, to get the indices of the physically adjacent cells?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names Shapely's polygon.is_valid and polygon.touches, plus poloidal indices, target plates, and X-points; begin by tracing how those topologies define physically adjacent cells. Compare the existing is_valid addition with the grid-generation flow, then define a topology-independent adjacency check and graphical problem marking. Done means twisted cells and neighboring overlaps are checked across each topology.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.