llnl / llnl/INGRID

Extend up/down symmetry option (add remaining topologies, support for separate HFS/LFS SOL width, documentation)

Open
#42 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
11
Forks
9
PR merge metrics
No merged PRs in 30d

Description

Up/down symmetry option has been added for SNL and some snowflake configurations (https://github.com/LLNL/INGRID/pull/37). The following should be done to finish off this work:

  • this option should be extended to all topologies supported by INGRID
  • documentation of this option should be added
  • currently only the lower half of the domain is kept, but it may sometimes be useful to keep only the upper half instead
  • currently for lower single null cases, the SOL width on the HFS and LFS are the same and set by psi_1. Instead, the SOL width on each side could be specified separately using psi_1 and psi_2

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the existing up/down symmetry implementation in PR #37 and tracing how the option is applied across supported topologies. Done means extending it to all topologies, documenting the option, supporting either retained half, and allowing separate HFS/LFS SOL widths via psi_1 and psi_2.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.