llnl / llnl/FPChecker

Function pointers should not be instrumented

Open
#10 1 comment 0 reactions 0 assignees View on GitHub
bug clang_plugin_branch
Dominant language
Python
Stars
44
Forks
13
PR merge metrics
No merged PRs in 30d

Description

This was incorrectly instrumented:

This line: `fptr[idx_dst] = (*fine_volumes)(SAMRAI::pdat::CellIndex(*bi));`
Became: `fptr[idx_dst] = _FPC_CHECK_((*fine_volumes)(SAMRAI::pdat::CellIndex(* bi), ), 125, “..ineOperator.cxx”);`

Here a function pointer is assigned to an array element.

Contributor guide

No contributing guide indexed for this repository

Research direction

Use the reported transformation of `fptr[idx_dst] = (*fine_volumes)(SAMRAI::pdat::CellIndex(*bi));` as the reproduction case, starting with the instrumentation logic that handles function-pointer assignments. Done means this assignment is left uninstrumented without the malformed `_FPC_CHECK_` wrapper, while the issue's broader floating-point instrumentation behavior remains intact.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
compilers, tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.