llnl / llnl/ExaCMech

Add debug check on deformation rate tensor

Open
#20 1 comment 0 reactions 1 assignee View on GitHub

@rcarson3 is already working on this.

Since Jan 20, 2022.

bug enhancement
Dominant language
C++
Stars
25
Forks
2
PR merge metrics
No merged PRs in 30d

Description

One of our users was recently trying to run the python code and was trying to do something like:

# Pure deviatoric case so no pressure produced
d_svec_kk_sm[0] = 0.5*erate
d_svec_kk_sm[1] = 0.5*erate
d_svec_kk_sm[2] = -1.0*erate
# expected this case to result in pressure
d_svec_kk_sm[0] = 0.0*erate
d_svec_kk_sm[1] = 0.0*erate
d_svec_kk_sm[2] = -1.0*erate

This made me realize that I should just provide a convenient wrapper for users that take in a velocity gradient (or gradients) that then produces the necessary deformation rate and spin tensors that ECMech uses. Next, it also made we realize that we have no check within the code to ensure the deformation tensor in our format is actually a deviatoric tensor + volume term. We should add a check at least in debug mode to at least ensure this is the case.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.