llnl / llnl/CcNav

Hidden windows in GoldenLayout asks for null reference when clicking on a code line.

Open
#3 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
6
Forks
1
PR merge metrics
No merged PRs in 30d

Description

If I hide some of the windows from CCNav default layout, and when I press any line of code in the "SourceCode" view to get the corresponding assembly, it works but a window alert occurs telling "TypeError: Cannot read properties of null (reading 'appendChild')". Here is a screenshot of this.

image_2022-02-04_10-42-35

Maybe this was done intentionally for debugging and forgot to remove the window.alert() line?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue in the CCNav default layout after hiding windows, then click a code line in the "SourceCode" view and inspect the GoldenLayout-related path that handles the assembly display. Done means the corresponding assembly still appears without the null-reference alert when windows are hidden; no test file is named in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.