llnl / llnl/Caliper

cmake-time logic to detect deps needed due to service enabled?

Open
#577 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
420
Forks
80
Avg merge
1d 12h
Merged PRs (30d)
9

Description

In downstream libs (conduit + ascent) we are resolving caliper deps with our cmake logic.

For example, we assume that adiak is being used and require folks tell us where adiak is.

But we don't need adiak in all cases.

We would like to only require it when the caliper build we are using requires it.

As far as I can tell, these services don't expose any headers, or other info that can be trivially searched to determine which dependencies are required for a given caliper build. May there is a config header we should look at that I missed?

Are there cmake config vars that can tell us what is enabled that can help us know what we need to resolve?

Longer term:
Would you be open to installed cmake logic that automatically finds the right dependencies + cmake targets?
We have some exemplars that can serve as a working solution to follow.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review the existing CMake dependency logic used by downstream Conduit and Ascent, focusing on how the Adiak dependency and Caliper services are detected. Determine whether installed configuration variables expose the enabled services and required dependencies, then compare the result with the downstream CMake exemplars. Done means documenting a viable detection approach or defining the scope for installed CMake logic that finds the required dependencies and targets.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake
Domain
build-system
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.