PointerRecord allocator default to -1.
Open
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 111
- Forks
- 23
- Avg merge
- 2d 7h
- Merged PRs (30d)
- 4
Description
I'm wondering if we should default to -1 since I believe 0 is a valid Umpire allocator ID.
_Originally posted by @adayton1 in https://github.com/LLNL/CHAI/pull/298#discussion_r2257896906_
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file or test is named in the issue. Locate the PointerRecord definition and its allocator initialization, then verify whether allocator ID 0 is valid and should remain distinguishable from the default -1. Confirm the change with the relevant existing tests or a focused test for the default value.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100